Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds student research form validations #166

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Adds student research form validations #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0c019a
🦺 Adds student research form validations
betsyecastro Oct 8, 2024
0ff3812
Adds validation for presence and length of intro, brief_intro and int…
betsyecastro Oct 8, 2024
6180385
Removes min length required for the intro, brief_intro and interest f…
betsyecastro Oct 10, 2024
d0f1608
Corrects the array key for the `major` field
betsyecastro Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/Http/Controllers/StudentsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace App\Http\Controllers;

use App\Events\StudentViewed;
use App\Http\Requests\StudentUpdateRequest;
use App\Student;
use App\StudentData;
use App\User;
Expand Down Expand Up @@ -50,7 +51,7 @@ public function index(): View|ViewContract
/**
* Create a new student research application.
*/
public function create(Request $request): RedirectResponse
public function create(StudentUpdateRequest $request): RedirectResponse
{
$student = $request->user()->studentProfiles->first() ?? $this->store($request);

Expand Down Expand Up @@ -127,7 +128,7 @@ public function edit(Student $student): View|ViewContract
/**
* Update the specified student research application in the database.
*/
public function update(Request $request, Student $student): RedirectResponse
public function update(StudentUpdateRequest $request, Student $student): RedirectResponse
{
$updated = $student->update([
'full_name' => $request->full_name,
Expand Down
137 changes: 137 additions & 0 deletions app/Http/Requests/StudentUpdateRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,137 @@
<?php

namespace App\Http\Requests;

use App\StudentData;
use Illuminate\Foundation\Http\FormRequest;
use Illuminate\Validation\Rule;
use Illuminate\Support\Str;

class StudentUpdateRequest extends FormRequest
{

/**
* Get the validation rules that apply to the request.
*
* @return array<string, \Illuminate\Contracts\Validation\Rule|array|string>
*/
public function rules(): array
{
return [
'full_name' => 'required|string',
'faculty.*' => [
'integer',
Rule::exists('profiles', 'id')->where('public', 1),
],
'research_profile.major' => 'required',
'research_profile.brief_intro' => [
'required',
'string',
'max:280',
],
'research_profile.intro' => [
'required',
'string',
'max:250',
],
'research_profile.interest' => [
'required',
'string',
'max:200',
],
'research_profile.semesters' => 'required|array|min:1',
'research_profile.schools' => 'required|array|min:1',
'research_profile.graduation_date' => 'required|date|after:today',
'research_profile.credit' => 'required|numeric|between:-1,1',
];
}

/**
* Get the error messages for the defined validation rules.
*
* @return array
*/
public function messages()
{
return [
'faculty.*.exists' => 'The faculty member(s) selected could not be validated.',
'faculty.required' => 'You must selest at least one faculty member that you would like to work with',
'research_profile.major' => 'The major field is required',
'research_profile.semesters.required' => 'At least one semester is required',
'research_profile.schools.required' => 'At least one school is required',
'research_profile.graduation_date.after' => 'The graduation date must be in the future',
'research_profile.credit.between' => 'The credit value is invalid',
];
}

/**
* Get custom attributes for validator errors.
*
* @return array
*/
public function attributes()
{
return [
'full_name' => 'display name',
'research_profile.semesters' => 'semesters',
'research_profile.schools' => 'school',
'research_profile.graduation_date' => 'graduation date',
'research_profile.credit' => 'credit',
'research_profile.brief_intro' => 'research opportunity reasons',
'research_profile.intro' => 'future goals',
'research_profile.interest' => 'interest',
];
}

public function withValidator($validator)
{
$validator->after(function ($validator) {
$semesters = $this->input('research_profile.semesters', []);
$availability = $this->input('research_profile.availability', []);
$schools = $this->input('research_profile.schools', []);
$custom_questions = StudentData::customQuestions();
$school_custom_questions = $this->input('research_profile.school_custom_questions', []);
$languages = $this->input('research_profile.languages', []);
$lang_proficiency = $this->input('research_profile.lang_proficiency', []);
$languages_attr = StudentData::$languages;
$hours_available = [
'hours' => 'per week',
'hours_weekdays' => 'per days',
'hours_weekends' => 'for weekends',
'hours_specific' => 'specific'
];

foreach ($semesters as $semester) { // Validates the presence of the hours availability based on the semesters selection
$semester_key = Str::lower(Str::replace(' ', '-', $semester));
if (!isset($availability[$semester_key])) {
$validator->errors()->add('availability.' . $semester_key, "The availability for $semester is required.");
}
else {
foreach ($hours_available as $hours => $frequency) {
if (is_null($availability[$semester_key][$hours])) {
$validator->errors()->add("availability.{$semester_key}.{$hours}", "The number of hours {$frequency} are required for $semester.");
}
}
}
}

foreach ($languages as $language) { // Validates the presence of the language proficiency based on the language selection
if (!array_key_exists($language, $lang_proficiency) || is_null($lang_proficiency[$language])) {
$validator->errors()->add("research_profile.lang_proficiency.{$language}", "The level of proficiency for $languages_attr[$language] is required.");
}
}

foreach ($schools as $key => $school) { // Validates the answers to the custom questions based on the school selection
if (!isset($school_custom_questions[$school])) {
$validator->errors()->add("research_profile.school_custom_questions.{$school}", "The specific questions for $school are required.");
}
foreach ($custom_questions[$school] as $question) {
if (!isset($school_custom_questions[$school][$question['name']])) {
$validator->errors()->add("research_profile.school_custom_questions.{$school}", "The specific questions for $school are required.");
}
}
}
});
}

}
10 changes: 10 additions & 0 deletions resources/views/students/edit.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,16 @@
<h1 class="mb-0">Student Research Application</h1>
<h2 class="mt-0 text-muted">for {{ $student->full_name }}</h2>

@if ($errors->any())
<div class="alert alert-danger alert-dismissable" role="alert">
<button type="button" class="close" data-dismiss="alert" aria-label="Close"><span aria-hidden="true">&times;</span></button>
<p><strong>There are some errors. Please correct them and try again.</strong></p>
@foreach ($errors->all() as $error)
{{ $error }}<br>
@endforeach
</div>
@endif

<div class="alert alert-success" role="alert">
<p class="mb-0">Complete and submit your student research application below. This application will not be public, but will be made available to faculty researchers who may be looking for students. After submitting, you can always come back later to edit or withdraw your student research application.</p>
</div>
Expand Down
8 changes: 4 additions & 4 deletions resources/views/students/form.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,24 +194,24 @@
@case('text')
<div class="col">
{!! Form::label("research_profile[{$question['name']}]", $question['label'], ['class' => 'form-label']) !!}
{!! Form::text("research_profile[{$question['name']}]", $student->research_profile?->{$question['name']}, ['class' => 'form-control']) !!}
{!! Form::text("research_profile[school_custom_questions][$school_shortname][{$question['name']}]", $student->research_profile?->{$question['name']}, ['class' => 'form-control']) !!}
</div>
@break
@case('textarea')
<div class="col">
{!! Form::label("research_profile[{$question['name']}]", $question['label'], ['class' => 'form-label']) !!}
{!! Form::textarea("research_profile[{$question['name']}]", $student->research_profile?->{$question['name']}, ['class' => 'form-control']) !!}
{!! Form::textarea("research_profile[school_custom_questions][$school_shortname][{$question['name']}]", $student->research_profile?->{$question['name']}, ['class' => 'form-control']) !!}
</div>
@break
@case('yes_no')
<strong class="col-lg-9">{!! $question['label'] !!}</strong>
<div class="col-lg-3">
<div class="form-check form-check-inline">
{!! Form::radio("research_profile[{$question['name']}]", '1', $student->research_profile->{$question['name']} === '1', ['id' => "{$question['name']}_yes", 'class' => 'form-check-input']) !!}
{!! Form::radio("research_profile[school_custom_questions][$school_shortname][{$question['name']}]", '1', $student->research_profile->{$question['name']} === '1', ['id' => "{$question['name']}_yes", 'class' => 'form-check-input']) !!}
{!! Form::label("{$question['name']}_yes", "Yes", ['class' => 'form-check-label']) !!}
</div>
<div class="form-check form-check-inline">
{!! Form::radio("research_profile[{$question['name']}]", '0', $student->research_profile->{$question['name']} === '0', ['id' => "{$question['name']}_no", 'class' => 'form-check-input']) !!}
{!! Form::radio("research_profile[school_custom_questions][$school_shortname][{$question['name']}]", '0', $student->research_profile->{$question['name']} === '0', ['id' => "{$question['name']}_no", 'class' => 'form-check-input']) !!}
{!! Form::label("{$question['name']}_no", "No", ['class' => 'form-check-label']) !!}
</div>
</div>
Expand Down
Loading