Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces data mixin with composable util. #372

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

charlon
Copy link
Member

@charlon charlon commented Jan 11, 2024

This PR gets rid of the data_mixin and replaces it with the composable equivalent. Please test locally make sure things are working as they should. I'm mainly concerned about the following files:

  • /stores/affiliations.js
  • /stores/student.js

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7482537767

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.829%

Totals Coverage Status
Change from base Build 7467635020: 0.0%
Covered Lines: 1704
Relevant Lines: 2756

💛 - Coveralls

@charlon charlon merged commit 36434c8 into develop Jan 12, 2024
4 checks passed
@jlaney jlaney deleted the feature/data-util branch June 25, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants