Skip to content

test: add a test for clicks on non visible grid columns #8587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mcollovati wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: add a test for clicks on non visible grid columns #8587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions ...ion-tests/src/main/java/com/vaadin/flow/component/grid/it/GridViewClickListenersPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,23 @@
@Route("vaadin-grid-it-demo/click-listeners")
public class GridViewClickListenersPage extends LegacyTestView {

private final Grid<Person> clickGrid;
private final Grid<Person> doubleClickGrid;

public GridViewClickListenersPage() {
createClickListener();
createDoubleClickListener();
clickGrid = createClickListener();
doubleClickGrid = createDoubleClickListener();
Button resizeGridsButton = new Button("Resize grids", event -> {
clickGrid.setWidth("100px");
clickGrid.getColumns().getFirst().setWidth("1000px");
doubleClickGrid.setWidth("100px");
doubleClickGrid.getColumns().getFirst().setWidth("1000px");
});
resizeGridsButton.setId("resize-grids");
add(resizeGridsButton);
}

private void createClickListener() {
private Grid<Person> createClickListener() {
Div message = new Div();
message.setId("clicked-item");

Expand Down Expand Up @@ -61,9 +72,11 @@ private void createClickListener() {

message.addClickListener(event -> message.setText(""));
addCard("Click Listeners", "Item Click Listener", message, grid);

return grid;
}

private void createDoubleClickListener() {
private Grid<Person> createDoubleClickListener() {
Div message = new Div();
message.setId("doubleclicked-item");

Expand All @@ -78,5 +91,7 @@ private void createDoubleClickListener() {
grid.setId("item-doubleclick-listener");
message.addClickListener(event -> message.setText(""));
addCard("Click Listeners", "Item Double Click Listener", message, grid);

return grid;
}
}
39 changes: 39 additions & 0 deletions ...ation-tests/src/test/java/com/vaadin/flow/component/grid/it/GridViewClickListenersIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
import org.openqa.selenium.By;
import org.openqa.selenium.WebElement;

import com.vaadin.flow.component.button.testbench.ButtonElement;
import com.vaadin.flow.component.grid.testbench.GridColumnElement;
import com.vaadin.flow.component.grid.testbench.GridElement;
import com.vaadin.flow.component.grid.testbench.GridTHTDElement;
import com.vaadin.flow.component.grid.testbench.GridTRElement;
Expand Down Expand Up @@ -120,4 +122,41 @@ public void itemDoubleClickListener() {
// No event
Assert.assertEquals("", clickInfo.getText());
}

@Test
public void nonVisibleColumn_itemClickListener() {
$(ButtonElement.class).id("resize-grids").click();

GridElement grid = $(GridElement.class).id("item-click-listener");
scrollToElement(grid);
waitUntil(driver -> grid.getRowCount() > 0);

GridColumnElement ageColumn = grid.getColumn("Age");
GridTRElement row = grid.getRow(0);
row.getCell(ageColumn).click();

WebElement clickInfo = findElement(By.id("clicked-item"));

Assert.assertEquals("Clicked Item: Person 1", clickInfo.getText());

}

@Test
public void nonVisibleColumn_itemDoubleClickListener() {
$(ButtonElement.class).id("resize-grids").click();

GridElement grid = $(GridElement.class).id("item-doubleclick-listener");
scrollToElement(grid);
waitUntil(driver -> grid.getRowCount() > 0);

GridColumnElement ageColumn = grid.getColumn("Age");
GridTRElement row = grid.getRow(0);
row.getCell(ageColumn).doubleClick();

WebElement clickInfo = findElement(By.id("doubleclicked-item"));

Assert.assertEquals("Double Clicked Item: Person 1",
clickInfo.getText());

}
}