Skip to content

Comments

chore: Fix compilation error and remove incorrect test#2136

Merged
mcollovati merged 1 commit intomainfrom
fix-signal-compilation-errors
Feb 20, 2026
Merged

chore: Fix compilation error and remove incorrect test#2136
mcollovati merged 1 commit intomainfrom
fix-signal-compilation-errors

Conversation

@mshabarov
Copy link
Contributor

Test removed because:

  1. Effect doesn't read any signal value.
  2. Effect uses setter that is prohibited while the binding is active.
  3. Another test covers already this scenario detachedComponent_triggerSignal_effectEvaluatedOnAttach, I think it's enough.

@mcollovati mcollovati enabled auto-merge (squash) February 20, 2026 10:25
@mcollovati mcollovati merged commit 4842249 into main Feb 20, 2026
10 checks passed
@mcollovati mcollovati deleted the fix-signal-compilation-errors branch February 20, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants