Skip to content

Comments

chore: Deprecate all classes in testbench-unit modules#2140

Open
Artur- wants to merge 5 commits intomainfrom
deprecate-ui-unit
Open

chore: Deprecate all classes in testbench-unit modules#2140
Artur- wants to merge 5 commits intomainfrom
deprecate-ui-unit

Conversation

@Artur-
Copy link
Member

@Artur- Artur- commented Feb 24, 2026

Mark all public classes, interfaces, enums, and annotations in the vaadin-testbench-unit-* modules as @deprecated(forRemoval = true) with a message directing users to migrate to Vaadin Browserless Test.

No implementation changes — only deprecation annotations and Javadoc @deprecated tags added. The existing code continues to work unchanged.

Mark all public classes, interfaces, enums, and annotations in the
vaadin-testbench-unit-* modules as @deprecated(forRemoval = true)
with a message directing users to migrate to Vaadin Browserless Test.

No implementation changes — only deprecation annotations and Javadoc
@deprecated tags added. The existing code continues to work unchanged.
@Artur- Artur- changed the title chore: Deprecate all classes in legacy testbench-unit modules chore: Deprecate all classes in testbench-unit modules Feb 24, 2026
@ZheSun88
Copy link
Contributor

maybe adding this message to the old artifacts is also useful

<project>
    <modelVersion>4.0.0</modelVersion>

    <groupId>com.old.group</groupId>
    <artifactId>old-artifact</artifactId>
    <version>1.0.1</version>
    <packaging>pom</packaging>

    <distributionManagement>
        <relocation>
            <groupId>com.new.group</groupId>
            <artifactId>new-artifact</artifactId>
            <version>2.0.0</version>
            <message>This artifact has moved to com.new.group:new-artifact</message>
        </relocation>
    </distributionManagement>
</project>

@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Test Results

 22 files   22 suites   21m 24s ⏱️
 83 tests  80 ✅ 3 💤 0 ❌
166 runs  160 ✅ 6 💤 0 ❌

Results for commit 73b2060.

♻️ This comment has been updated with latest results.

@Artur-
Copy link
Member Author

Artur- commented Feb 25, 2026

now there is relocation info but that logs the message 293 times in the validation build..

Copy link
Contributor

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relocation message seems a bit incomplete: just changing packages is not enough to migrate since also base tests classes had names changed.
And JUnit 4 test cannot be migrated without JUnit 6 migration.
Maybe put a link to the new migration guide in there?

@mcollovati
Copy link
Contributor

Is it so that relocation automatically downloads and replaces the artifact with the new one?
If so, this means that the existing project will break immediately.

@mcollovati
Copy link
Contributor

I propose to remove the relocation stuff, since this is not a drop-in without side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants