fix: Make ClassGraph discover package-private @Route views#2142
Closed
fix: Make ClassGraph discover package-private @Route views#2142
Conversation
ClassGraph's default scan only returns public classes. Add ignoreClassVisibility() to the route auto-discovery scan so package-private views annotated with @route are found.
Artur-
force-pushed
the
fix-route-scan
branch
from
46cc3d7 to
637f74a
Compare
mcollovati
reviewed
Feb 25, 2026
Contributor
mcollovati
left a comment
mcollovati
left a comment
There was a problem hiding this comment.
Can we add a simple test, like DiscoverRoutesInAnnotatedClassPackageTest in browserless-test/junit6/src/test/java/com/vaadin/browserless/viewscan/nonpubliclass pacakge to prevent future regressions?
Adds a package-private view (PackagePrivateView) and a dedicated test to verify that autoDiscoverViews() finds non-public @route views.
Member
Author
|
added |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassGraph's default scan only returns public classes. Add ignoreClassVisibility() to the route auto-discovery scan so package-private views annotated with @route are found