Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fixed problem with nightly build after updating dependencies #283

Merged
merged 7 commits into from
Feb 21, 2025
Merged

ci: fixed problem with nightly build after updating dependencies #283

merged 7 commits into from
Feb 21, 2025

Conversation

seemenkina
Copy link
Collaborator

Return the exception settings for run-cli. Also remove the build for the x32 architecture, because the new version of ark-circom depends on wasmer-wasix, which cannot be built on the x32 architecture.

See this issue for more details: #282

@seemenkina seemenkina self-assigned this Feb 20, 2025
@github-actions GitHub Actions
Copy link

Benchmark for c384063

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 869.5±5.77ns 872.2±15.83ns +0.31%
FullMerkleTree::get 3.5±0.07ns 3.5±0.07ns 0.00%
FullMerkleTree::get_empty_leaves_indices 7.5±0.19ns 7.8±0.22ns +4.00%
FullMerkleTree::get_subtree_root 3.7±0.10ns 3.7±0.09ns 0.00%
FullMerkleTree::override_range 1335.2±9.77ns 1366.2±8.92ns +2.32%
FullMerkleTree::set 877.2±9.84ns 894.2±5.22ns +1.94%
OptimalMerkleTree::compute_root 1005.2±6.12ns 1006.2±6.90ns +0.10%
OptimalMerkleTree::delete 1003.4±9.58ns 1005.2±25.00ns +0.18%
OptimalMerkleTree::get 22.2±0.25ns 22.2±0.20ns 0.00%
OptimalMerkleTree::get_empty_leaves_indices 7.5±0.12ns 7.5±0.06ns 0.00%
OptimalMerkleTree::get_subtree_root 24.0±0.76ns 23.9±0.32ns -0.42%
OptimalMerkleTree::override_range 4.1±0.03µs 4.2±0.21µs +2.44%
OptimalMerkleTree::set 1001.4±18.98ns 999.8±18.26ns -0.16%

@github-actions GitHub Actions
Copy link

Benchmark for c384063

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 13.6±0.10ms 13.5±0.16ms -0.74%
OptimalMerkleTree::::full_height_gen 583.9±3.83µs 584.0±10.60µs +0.02%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 356.2±4.52ns 357.9±4.79ns +0.48%
Pmtree::get_empty_leaves_indices 9.0±0.12ns 9.0±0.13ns 0.00%
Pmtree::get_subtree_root 515.9±6.89ns 513.0±6.59ns -0.56%
Pmtree::override_range 239.0±5.37µs 247.6±5.32µs +3.60%
Pmtree::set 54.6±0.46µs 54.6±0.60µs 0.00%
Pmtree:delete 54.6±0.61µs 54.7±1.06µs +0.18%
Set/FullMerkleTree::::set/1 564.4±9.24µs 563.8±4.08µs -0.11%
Set/FullMerkleTree::::set/10 5.7±0.01ms 5.8±0.04ms +1.75%
Set/FullMerkleTree::::set/100 56.5±0.19ms 56.4±0.14ms -0.18%
Set/FullMerkleTree::::set_range/1 563.6±5.81µs 562.1±4.21µs -0.27%
Set/FullMerkleTree::::set_range/10 768.6±4.67µs 765.8±4.99µs -0.36%
Set/FullMerkleTree::::set_range/100 3.3±0.03ms 3.3±0.01ms 0.00%
Set/OptimalMerkleTree::::set/1 563.7±7.38µs 563.3±5.85µs -0.07%
Set/OptimalMerkleTree::::set/10 5.6±0.02ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set/100 56.3±0.16ms 56.3±0.21ms 0.00%
Set/OptimalMerkleTree::::set_range/1 566.4±5.91µs 562.1±3.12µs -0.76%
Set/OptimalMerkleTree::::set_range/10 5.7±0.02ms 5.6±0.02ms -1.75%
Set/OptimalMerkleTree::::set_range/100 56.9±0.08ms 56.4±0.18ms -0.88%
vk::vk_from_ark_serialized 1620.2±7.70ns 1618.6±6.02ns -0.10%
zkey::zkey_from_raw 3.4±0.00s 3.4±0.00s 0.00%

@github-actions GitHub Actions
Copy link

Benchmark for c384063

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 13.6±0.10ms 13.2±0.09ms -2.94%
OptimalMerkleTree::::full_height_gen 579.1±4.07µs 577.1±3.03µs -0.35%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 356.1±4.21ns 354.0±8.17ns -0.59%
Pmtree::get_empty_leaves_indices 8.7±0.12ns 8.7±0.06ns 0.00%
Pmtree::get_subtree_root 512.3±7.64ns 512.1±12.10ns -0.04%
Pmtree::override_range 236.3±3.73µs 248.5±5.20µs +5.16%
Pmtree::set 54.6±0.57µs 54.3±0.55µs -0.55%
Pmtree:delete 55.0±2.92µs 54.3±0.42µs -1.27%
Set/FullMerkleTree::::set/1 556.9±12.68µs 558.1±4.04µs +0.22%
Set/FullMerkleTree::::set/10 5.6±0.02ms 5.6±0.02ms 0.00%
Set/FullMerkleTree::::set/100 55.5±0.11ms 55.7±0.16ms +0.36%
Set/FullMerkleTree::::set_range/1 555.5±3.13µs 558.5±6.43µs +0.54%
Set/FullMerkleTree::::set_range/10 755.5±5.70µs 756.9±17.65µs +0.19%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.02ms 0.00%
Set/OptimalMerkleTree::::set/1 559.0±2.71µs 558.9±4.75µs -0.02%
Set/OptimalMerkleTree::::set/10 5.6±0.02ms 5.6±0.05ms 0.00%
Set/OptimalMerkleTree::::set/100 55.9±2.06ms 56.0±1.82ms +0.18%
Set/OptimalMerkleTree::::set_range/1 559.2±5.44µs 558.3±16.57µs -0.16%
Set/OptimalMerkleTree::::set_range/10 5.6±0.03ms 5.6±0.04ms 0.00%
Set/OptimalMerkleTree::::set_range/100 55.8±0.17ms 55.7±0.10ms -0.18%
arkzkey::arkzkey_from_raw_compressed 338.2±1.01ms 338.3±0.90ms +0.03%
arkzkey::arkzkey_from_raw_uncompressed 6.1±0.02ms 6.0±0.04ms -1.64%
vk::vk_from_ark_serialized 1607.9±41.93ns 1634.2±13.75ns +1.64%
zkey::zkey_from_raw 3.4±0.01s 3.4±0.01s 0.00%

@seemenkina seemenkina requested a review from vinhtc27 February 20, 2025 14:40
@github-actions GitHub Actions
Copy link

Benchmark for bc925ef

Click to view benchmark
Test Base PR %
FullMerkleTree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
FullMerkleTree::delete 876.4±8.44ns 871.4±10.59ns -0.57%
FullMerkleTree::get 3.4±0.03ns 3.5±0.07ns +2.94%
FullMerkleTree::get_empty_leaves_indices 7.9±0.48ns 7.5±0.09ns -5.06%
FullMerkleTree::get_subtree_root 3.6±0.08ns 3.7±0.11ns +2.78%
FullMerkleTree::override_range 1340.8±11.05ns 1335.2±24.00ns -0.42%
FullMerkleTree::set 870.6±14.09ns 879.1±32.99ns +0.98%
OptimalMerkleTree::compute_root 1021.3±34.44ns 1018.5±54.99ns -0.27%
OptimalMerkleTree::delete 1015.7±24.62ns 1013.5±19.04ns -0.22%
OptimalMerkleTree::get 25.0±0.56ns 22.0±0.35ns -12.00%
OptimalMerkleTree::get_empty_leaves_indices 7.5±0.11ns 7.5±0.12ns 0.00%
OptimalMerkleTree::get_subtree_root 24.4±0.14ns 24.1±0.56ns -1.23%
OptimalMerkleTree::override_range 4.2±0.03µs 4.1±0.13µs -2.38%
OptimalMerkleTree::set 1004.5±9.54ns 1012.5±20.42ns +0.80%

@github-actions GitHub Actions
Copy link

Benchmark for bc925ef

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 13.4±0.15ms 13.7±0.11ms +2.24%
OptimalMerkleTree::::full_height_gen 584.2±4.40µs 584.5±9.94µs +0.05%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 365.6±4.79ns 357.9±5.26ns -2.11%
Pmtree::get_empty_leaves_indices 8.7±0.11ns 8.7±0.07ns 0.00%
Pmtree::get_subtree_root 520.8±8.67ns 524.7±21.22ns +0.75%
Pmtree::override_range 236.4±3.07µs 241.1±5.20µs +1.99%
Pmtree::set 54.6±0.42µs 54.6±0.75µs 0.00%
Pmtree:delete 54.6±0.57µs 54.7±1.51µs +0.18%
Set/FullMerkleTree::::set/1 561.7±4.63µs 565.8±4.57µs +0.73%
Set/FullMerkleTree::::set/10 5.6±0.01ms 5.6±0.01ms 0.00%
Set/FullMerkleTree::::set/100 56.0±0.25ms 56.3±0.34ms +0.54%
Set/FullMerkleTree::::set_range/1 560.5±6.55µs 561.7±3.64µs +0.21%
Set/FullMerkleTree::::set_range/10 763.6±5.81µs 763.7±3.88µs +0.01%
Set/FullMerkleTree::::set_range/100 3.3±0.01ms 3.3±0.01ms 0.00%
Set/OptimalMerkleTree::::set/1 564.3±11.56µs 562.6±3.89µs -0.30%
Set/OptimalMerkleTree::::set/10 5.6±0.02ms 5.6±0.05ms 0.00%
Set/OptimalMerkleTree::::set/100 56.0±0.12ms 56.5±0.14ms +0.89%
Set/OptimalMerkleTree::::set_range/1 560.3±6.42µs 563.8±4.11µs +0.62%
Set/OptimalMerkleTree::::set_range/10 5.6±0.02ms 5.6±0.01ms 0.00%
Set/OptimalMerkleTree::::set_range/100 56.2±0.19ms 56.8±1.82ms +1.07%
vk::vk_from_ark_serialized 1642.8±4.16ns 1645.9±22.13ns +0.19%
zkey::zkey_from_raw 3.4±0.01s 3.4±0.01s 0.00%

@github-actions GitHub Actions
Copy link

Benchmark for bc925ef

Click to view benchmark
Test Base PR %
FullMerkleTree::::full_height_gen 13.7±0.18ms 14.1±0.22ms +2.92%
OptimalMerkleTree::::full_height_gen 578.5±3.98µs 579.7±3.73µs +0.21%
Pmtree::compute_root 0.0±0.00ns 0.0±0.00ns NaN%
Pmtree::get 360.3±4.16ns 362.7±3.71ns +0.67%
Pmtree::get_empty_leaves_indices 8.7±0.13ns 8.7±0.07ns 0.00%
Pmtree::get_subtree_root 515.2±8.55ns 516.3±6.30ns +0.21%
Pmtree::override_range 250.8±4.47µs 240.4±4.90µs -4.15%
Pmtree::set 54.2±0.52µs 54.4±0.42µs +0.37%
Pmtree:delete 54.3±0.66µs 54.3±0.57µs 0.00%
Set/FullMerkleTree::::set/1 557.5±5.89µs 554.8±4.22µs -0.48%
Set/FullMerkleTree::::set/10 5.5±0.02ms 5.5±0.03ms 0.00%
Set/FullMerkleTree::::set/100 55.8±0.42ms 55.4±0.18ms -0.72%
Set/FullMerkleTree::::set_range/1 558.1±5.19µs 554.5±7.38µs -0.65%
Set/FullMerkleTree::::set_range/10 759.1±7.97µs 753.7±6.41µs -0.71%
Set/FullMerkleTree::::set_range/100 3.3±0.22ms 3.3±0.02ms 0.00%
Set/OptimalMerkleTree::::set/1 559.1±12.38µs 555.9±7.39µs -0.57%
Set/OptimalMerkleTree::::set/10 5.6±0.04ms 5.6±0.02ms 0.00%
Set/OptimalMerkleTree::::set/100 55.6±0.15ms 55.6±0.12ms 0.00%
Set/OptimalMerkleTree::::set_range/1 554.7±5.68µs 555.2±7.76µs +0.09%
Set/OptimalMerkleTree::::set_range/10 5.6±0.31ms 5.6±0.17ms 0.00%
Set/OptimalMerkleTree::::set_range/100 55.9±0.16ms 55.6±0.30ms -0.54%
arkzkey::arkzkey_from_raw_compressed 338.8±1.32ms 338.6±1.04ms -0.06%
arkzkey::arkzkey_from_raw_uncompressed 6.0±0.02ms 6.0±0.03ms 0.00%
vk::vk_from_ark_serialized 1604.5±24.69ns 1609.8±21.78ns +0.33%
zkey::zkey_from_raw 3.5±0.01s 3.5±0.01s 0.00%

@seemenkina seemenkina merged commit 1930ca1 into master Feb 21, 2025
13 checks passed
@seemenkina seemenkina deleted the ci-fix-nightly-release branch February 21, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinhtc27 vinhtc27 vinhtc27 approved these changes

Assignees

@seemenkina seemenkina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seemenkina @vinhtc27