fix(workspace): running-agent click — no duplicate spawn, no dead-click#255
Merged
Conversation
- jumpToRunningAgent: the agent is already running, so clicking a row must not prefill a resume command (that started a 2nd instance) and must not dead-click when the session isn't indexed. Now: jump to the live pane if one exists, else open a plain terminal in the project folder — no resume, no silent no-op. - _wsRenderRunningTree: change-detection signature now keys on the full cwd, not the folder basename, so two same-named projects (or a swap) can't reuse a stale tree / wrong jump target. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in the v7.14.4 sidebar "Running agents" tree, found while it was in use.
Duplicate-spawn / dead-click (
jumpToRunningAgent): clicking a running-agent row calledopenSessionInWorkspace, which prefills a resume command. But the agent is already running → that starts a second instance. And if the session isn't indexed in the dashboard,openSessionInWorkspacereturns silently → the click does nothing. Fix: jump to the live pane if one exists; otherwise open a plain terminal in the project folder (no resume, no no-op).Stale change-detection (
_wsRenderRunningTree): the_wsRunTreeSigsignature keyed on the folder basename instead of the fullcwd, so two same-named projects (or one stopping while another same-named starts with the same agents) could reuse a stale tree and jump to the wrong folder. Now keyed on fullcwd.No version bump — batching into the next patch release.
🤖 Generated with Claude Code