fix(pi): reuse delayed header parsing in detail view#260
Merged
vakovalskii merged 1 commit intoJul 21, 2026
Conversation
Owner
|
Exactly the follow-up from #231 — thanks for circling back! Extracting |
Merged
vakovalskii
added a commit
that referenced
this pull request
Jul 21, 2026
Ships the changes merged since 7.14.5: native Add-project folder picker (desktop), Oh My Pi title-before-session parsing (#231/#260), GitHub avatar CSP fix (#249), Overview/Recommended full-width tiles (#243), Neuraldeep footer, and signed-release docs + manual npm publish workflow. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sessionrecord when metadata lines precede itWhy
PR #231 fixed session scanning for newer Oh My Pi logs that can write a
titlemetadata record before thesessionrecord. The detail loader still had the oldline 1 is headerassumption. It did not break current message display because it ignores non-message records, but reusing the same header detection keeps both code paths consistent and avoids future drift if more pre-header metadata appears.Validation
node --check src/data.jsnode --test test/pi-session.test.js→ 15 pass, 0 fail