fix: Kiro maxBuffer + ToolUse (#230 pt1), robust terminal fit (#259)#264
Merged
Conversation
Kiro (from PR #230 review, part 1 — the confirmed, mergeable half): - Add maxBuffer (50MB) to the scanKiroSessions + loadKiroDetail sqlite3 calls. Without it, a large conversations_v2 value blows past the 1MB default and the call throws ENOBUFS, so the Kiro session list / detail came back empty. - Also read assistant.ToolUse turns (not just Response), which Kiro now emits. Workspace terminal (#259 — distortion at 2560×1440): - Fit only when the host has a real size, defer the initial fit to rAF, and re-fit + push a resize to the pty on 'ready'. Fitting a zero-size / not-yet- laid-out host spawned the pty at the wrong width and garbled full-screen TUIs like Claude Code, most visibly on large / hi-DPI displays. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kiro — from PR #230 review (part 1, the confirmed mergeable half; @Sean10)
maxBuffer: 50MBto thescanKiroSessions+loadKiroDetailsqlite3 calls. A largeconversations_v2value exceeds the 1 MB default → the call throwsENOBUFS→ the Kiro session list / detail came back empty.assistant.ToolUseturns in addition toResponse(Kiro now emits ToolUse), so those turns are no longer dropped.(PR #230's part 2 — the new file-based
~/.kiro/sessions/cli/format — is left for the contributor to finish, since it still needs wiring intofindSessionFile/_buildSessionFileIndex+ a UUID guard, per the review.)Workspace terminal — #259 (Claude Code UI distorts at 2560×1440)
fit.fit()ran synchronously right afterterm.open(), which can measure a zero-size / not-yet-laid-out host (inactive tab, mid-transition pane); the pty then spawned at the wrong width and garbled full-screen TUIs, most visibly on large / hi-DPI displays. Now: fit only when the host has a real size, defer the initial fit torequestAnimationFrame, and re-fit + push aresizeto the pty onreadyso xterm and the pty always agree. The ResizeObserver uses the same guarded fit.Fixes #259. Tests green (0 fail). @dedyyshka — please retest on your 2560×1440 screen after the next release.
🤖 Generated with Claude Code