Infer the git remote from the branch name#624
Merged
mbaldessari merged 1 commit intovalidatedpatterns:mainfrom May 28, 2025
Merged
Infer the git remote from the branch name#624mbaldessari merged 1 commit intovalidatedpatterns:mainfrom
mbaldessari merged 1 commit intovalidatedpatterns:mainfrom
Conversation
this is better than assuming it's called `origin` because in many cases people want to use forks on the same local directory
This was referenced May 12, 2025
mbaldessari
reviewed
May 13, 2025
Contributor
mbaldessari
left a comment
mbaldessari
left a comment
There was a problem hiding this comment.
I like this. It is probably best to move the TARGET_REPO definition after TARGET_BRANCH and TARGET_ORIGIN. Makefile might be smart enough to resolve things properly, but it's best to be clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is better than assuming it's called
originbecause in many casespeople want to use forks on the same local directory