Add ability to specify CIDR in vals.yml#15
Open
eduffy-redhat wants to merge 3 commits intovalidatedpatterns:mainfrom
Open
Add ability to specify CIDR in vals.yml#15eduffy-redhat wants to merge 3 commits intovalidatedpatterns:mainfrom
eduffy-redhat wants to merge 3 commits intovalidatedpatterns:mainfrom
Conversation
Added 3 properties (machine_cidr, cluster_cidr, and service_cidr) to set the subnet CIDR for each respective network in the cluster
Forgot that one :)
`hcp create cluster aws --help` literally says that it accepts an array strings for CIDRs, but it failed saying it could not parse the CIDR.... Changed it to be just a single string and it works fine now...
Author
|
Should squash and merge when ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 4 properties (vpc_cidr, machine_cidr, cluster_cidr, and service_cidr) to set
the subnet CIDR for each respective network in the cluster