Merged
Conversation
This makes it easier to override/merge
Note that we cannot use the sharedValueFiles field. This does not work on the clusterwise ardocd instance on the spokes. This is because the helm template resolution happens on the hub and so it won't reflect the values on the spokes.
Tested the whole set as follows: - hub on 4.20 + spokes on 4.19 and 4.20 -> All green - hub on 4.19 + spoke on 4.19 -> All green
Use the supported ESO when using OCP 4.20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync-branches: New code has just landed in main, so let's bring rhdp-deploy up to speed!