Skip to content

Comments

fix(ansible): add error handling and explicit configuration#556

Merged
mbaldessari merged 1 commit intovalidatedpatterns:mainfrom
brianredbeard:brb-pr556
Jan 19, 2026
Merged

fix(ansible): add error handling and explicit configuration#556
mbaldessari merged 1 commit intovalidatedpatterns:mainfrom
brianredbeard:brb-pr556

Conversation

@brianredbeard
Copy link
Contributor

@brianredbeard brianredbeard commented Jan 15, 2026

Changes

site.yaml:

  • Add task to verify pattern.sh exists before execution
  • Use playbook_dir instead of PWD lookup for reliable path resolution
  • Add failed_when condition to properly handle command failures
  • Print stdout_lines instead of full output object
  • Conditionally print stderr if present

ansible.cfg:

  • Add interpreter_python=auto_silent to suppress interpreter warnings
  • Add timeout=30 to prevent hanging on slow systems
  • Add comment documenting why retry_files_enabled is False

Test Plan

  • Run ansible-playbook --syntax-check ansible/site.yaml
  • Verify playbook runs correctly from different working directories
  • Confirm script existence check fails gracefully when pattern.sh is missing

Fixes #543
Fixes #544
Fixes #545
Fixes #546
Fixes #547
Fixes #548
Fixes #549
Fixes #550
Fixes #551

@brianredbeard
fix(ansible): add error handling and explicit configuration
f436d12 
site.yaml:
- Add task to verify pattern.sh exists before execution
- Use playbook_dir instead of PWD lookup for reliable path resolution
- Add failed_when condition to properly handle command failures
- Print stdout_lines instead of full output object
- Conditionally print stderr if present

ansible.cfg:
- Add interpreter_python=auto_silent to suppress interpreter warnings
- Add timeout=30 to prevent hanging on slow systems
- Add comment documenting why retry_files_enabled is False
@brianredbeard brianredbeard mentioned this pull request Jan 15, 2026
Closed
@mbaldessari mbaldessari merged commit ba148c0 into validatedpatterns:main Jan 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment