Conversation
sauagarwa
requested changes
Jan 19, 2026
sauagarwa
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new pgvector option to the rag-llm chart so users can choose a local PGVector deployment alongside the existing EDB/Redis/Elastic options. This included bringing in the pgvector subchart, gating it on global.db.type, aligning its secret output with the existing vectordb-app contract, and updating the app/job templates to treat EDB and pgvector consistently. I also documented the new option in values-global.yaml/README.md, and fixed the EDB pull secret ExternalSecret template so the token is rendered correctly from Vault.