Skip to content

test: split tests of large validators #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
229 changes: 1 addition & 228 deletions test/sanitizers.test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { format } from 'util';
import validator from '../src/index';

function test(options) {
export default function test(options) {
let args = options.args || [];

args.unshift(null);
Expand Down Expand Up @@ -284,231 +284,4 @@ describe('Sanitizers', () => {
},
});
});

it('should normalize an email based on domain', () => {
test({
sanitizer: 'normalizeEmail',
expect: {
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'hans@m端ller.com': 'hans@m端ller.com',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'"foo@bar"@baz.com': '"foo@bar"@baz.com',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'@gmail.com': false,
'@icloud.com': false,
'@outlook.com': false,
'@yahoo.com': false,
},
});

// Testing all_lowercase switch, should apply to domains not known to be case-insensitive
test({
sanitizer: 'normalizeEmail',
args: [{ all_lowercase: false }],
expect: {
'[email protected]': '[email protected]',
'hans@m端ller.com': 'hans@m端ller.com',
'[email protected]': '[email protected]', // Hostname is always lowercased
'[email protected]': '[email protected]',
// In case of domains that are known to be case-insensitive, there's a separate switch
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
},
});

// Testing *_lowercase
test({
sanitizer: 'normalizeEmail',
args: [{
all_lowercase: false,
gmail_lowercase: false,
icloud_lowercase: false,
outlookdotcom_lowercase: false,
yahoo_lowercase: false,
yandex_lowercase: false,
}],
expect: {
'[email protected]': '[email protected]', // all_lowercase
'[email protected]': '[email protected]', // gmail_lowercase
'[email protected]': '[email protected]', // icloud_lowercase
'[email protected]': '[email protected]', // icloud_lowercase
'[email protected]': '[email protected]', // outlookdotcom_lowercase
'[email protected]': '[email protected]', // outlookdotcom_lowercase
'[email protected]': '[email protected]', // yahoo_lowercase
'[email protected]': '[email protected]', // yandex_lowercase
},
});

// Testing all_lowercase
// Should overwrite all the *_lowercase options
test({
sanitizer: 'normalizeEmail',
args: [{
all_lowercase: true,
gmail_lowercase: false, // Overruled
icloud_lowercase: false, // Overruled
outlookdotcom_lowercase: false, // Overruled
yahoo_lowercase: false, // Overruled
}],
expect: {
'[email protected]': '[email protected]', // all_lowercase
'[email protected]': '[email protected]', // gmail_lowercase
'[email protected]': '[email protected]', // icloud_lowercase
'[email protected]': '[email protected]', // icloud_lowercase
'[email protected]': '[email protected]', // outlookdotcom_lowercase
'[email protected]': '[email protected]', // outlookdotcom_lowercase
'[email protected]': '[email protected]', // yahoo_lowercase
},
});

// Testing *_remove_dots
test({
sanitizer: 'normalizeEmail',
args: [{
gmail_remove_dots: false,
}],
expect: {
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
},
});

test({
sanitizer: 'normalizeEmail',
args: [{
gmail_remove_dots: true,
}],
expect: {
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
},
});

// Testing *_remove_subaddress
test({
sanitizer: 'normalizeEmail',
args: [{
gmail_remove_subaddress: false,
icloud_remove_subaddress: false,
outlookdotcom_remove_subaddress: false,
yahoo_remove_subaddress: false, // Note Yahoo uses "-"
}],
expect: {
'[email protected]': '[email protected]',
'[email protected]': '[email protected]', // gmail_remove_subaddress
'[email protected]': '[email protected]', // icloud_remove_subaddress
'[email protected]': '[email protected]', // icloud_remove_subaddress
'[email protected]': '[email protected]', // outlookdotcom_remove_subaddress
'[email protected]': '[email protected]', // outlookdotcom_remove_subaddress
'[email protected]': '[email protected]', // yahoo_remove_subaddress
'[email protected]': '[email protected]', // yahoo_remove_subaddress
},
});

test({
sanitizer: 'normalizeEmail',
args: [{
gmail_remove_subaddress: true,
icloud_remove_subaddress: true,
outlookdotcom_remove_subaddress: true,
yahoo_remove_subaddress: true, // Note Yahoo uses "-"
}],
expect: {
'[email protected]': '[email protected]',
'[email protected]': '[email protected]', // gmail_remove_subaddress
'[email protected]': '[email protected]', // icloud_remove_subaddress
'[email protected]': '[email protected]', // icloud_remove_subaddress
'[email protected]': '[email protected]', // outlookdotcom_remove_subaddress
'[email protected]': '[email protected]', // outlookdotcom_remove_subaddress
'[email protected]': '[email protected]', // yahoo_remove_subaddress
'[email protected]': '[email protected]', // yahoo_remove_subaddress
},
});

// Testing gmail_convert_googlemaildotcom
test({
sanitizer: 'normalizeEmail',
args: [{
gmail_convert_googlemaildotcom: false,
}],
expect: {
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
},
});

test({
sanitizer: 'normalizeEmail',
args: [{
gmail_convert_googlemaildotcom: true,
}],
expect: {
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
},
});

// Testing yandex_convert_yandexru
test({
sanitizer: 'normalizeEmail',
args: [{
yandex_convert_yandexru: false,
}],
expect: {
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
},
});

test({
sanitizer: 'normalizeEmail',
args: [{
yandex_convert_yandexru: true,
}],
expect: {
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
'[email protected]': '[email protected]',
},
});
});
});
Loading