Skip to content

Add Qatar phone number validation #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Qatar phone number validation #2556

wants to merge 4 commits into from

Conversation

WardKhaddour
Copy link

  • Updated phone object in isMobilePhone validator adding ar-QA regex
  • Added isMobilePhone.test.js with Qatar phone number tests

Checklist

  • PR contains only changes related; no stray files, etc.
  • Tests written

@WardKhaddour
add qatar phone numbers validation
677c3b7 
create ar-QA field in phones object with correct regex
added isMobilePhone.test.js file with test cases for qatar mobile phones
@WardKhaddour
Merge pull request #1 from WardKhaddour/add-qatari-phone-number-valid…
6b05e68 
…ation

add qatar phone numbers validation
@codecov Codecov
Copy link

codecov bot commented Apr 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d07eae6) to head (3977d8f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #2556   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          114       114           
  Lines         2535      2535           
  Branches       641       641           
=========================================
  Hits          2535      2535

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

WikiRik
WikiRik requested changes Apr 21, 2025
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regex conforms with https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000AB0002PDFE.pdf

@WardKhaddour
resolve issues
59310d1
@WardKhaddour
Apply requested changes
3977d8f 
- [] Remover en-QA .
- [] Changed ar-QA Regex.
- [] Added all tests inside validatior.test.js file.
@WardKhaddour WardKhaddour requested a review from WikiRik April 21, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik Awaiting requested review from WikiRik

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WardKhaddour @WikiRik