Skip to content

Conversation

@fearoff999
Copy link

In PR #2603 checks failed on old versions of nodejs (cause of object.entries not a function)

In this PR polyfill for object.entries was added if doesnt available at current environment

@fearoff999 fearoff999 closed this Oct 14, 2025
@fearoff999 fearoff999 reopened this Oct 14, 2025
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.72%. Comparing base (6f436be) to head (ec41147).

Files with missing lines Patch % Lines
src/lib/compatibility/objectEntries.js 0.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2604      +/-   ##
===========================================
- Coverage   100.00%   99.72%   -0.28%     
===========================================
  Files          114      115       +1     
  Lines         2536     2544       +8     
  Branches       642      643       +1     
===========================================
+ Hits          2536     2537       +1     
- Misses           0        6       +6     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fearoff999 fearoff999 closed this Oct 14, 2025
@WikiRik
Copy link
Member

WikiRik commented Oct 14, 2025

Thanks for trying to solve this issue! I think we need to update the package.json to override the dependency that babel has updated which breaks Node 6 compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants