Fix(isLength): Correctly handle Unicode variation selectors #2616
+46
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the validator would subtract all Unicode variation selectors (
\uFE0F,\uFE0E) from a string's total length. This allowed for a string to contain a potentially infinite number of these characters while still passing a max length validation. For example, a string like "test\uFE0F\uFE0F\uFE0F..." could easily bypass a max: 4 check.Variation selectors are now only discounted from the length if they directly follow a base character they are modifying. If they appear at the start of a string or in a sequence, they are correctly counted towards the total length.
References:
Checklist