-
Notifications
You must be signed in to change notification settings - Fork 3
Add git-secrets-scan workflow
#146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new GitHub Actions workflow to scan for secrets and sensitive information using the git-secrets tool. The workflow runs on pushes to main and release branches to help prevent accidental commits of passwords, API keys, and other credentials.
- Adds automated secret scanning using git-secrets from AWS Labs
- Configures workflow to run on main, release-, and v branches with manual trigger support
- Sets up concurrency controls to cancel redundant runs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6438a90 to
bd23a4c
Compare
|
Steps for running locally: brew install git-secrets
cd <ROOT_DIR>
git secrets --register-aws
git secrets --scan |
xShinnRyuu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yipin-chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CIs are red.
7dbac4f to
2df5993
Compare
affonsov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
affonsov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to be part of the pull request workflow
Signed-off-by: currantw <[email protected]>
Change git-secrets workflow to trigger on pull_request events rather than push events to main/release branches. This prevents secrets from being merged rather than detecting them after the fact. Addresses review feedback to catch secrets before merge. Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
2df5993 to
a0e92cb
Compare
Adds a git-secrets-scan workflow that installs and executes git-secrets on pushes to
mainand release branches. This helps to ensure that passwords, secrets, and other sensitive information does not get committed.