Skip to content

Conversation

@currantw
Copy link
Collaborator

@currantw currantw commented Nov 17, 2025

Adds a git-secrets-scan workflow that installs and executes git-secrets on pushes to main and release branches. This helps to ensure that passwords, secrets, and other sensitive information does not get committed.

@currantw currantw self-assigned this Nov 17, 2025
@currantw currantw requested a review from a team as a code owner November 17, 2025 21:34
@currantw currantw requested review from affonsov and Copilot November 17, 2025 21:34
Copilot finished reviewing on behalf of currantw November 17, 2025 21:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new GitHub Actions workflow to scan for secrets and sensitive information using the git-secrets tool. The workflow runs on pushes to main and release branches to help prevent accidental commits of passwords, API keys, and other credentials.

  • Adds automated secret scanning using git-secrets from AWS Labs
  • Configures workflow to run on main, release-, and v branches with manual trigger support
  • Sets up concurrency controls to cancel redundant runs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@currantw currantw force-pushed the currantw/git-secrets branch from 6438a90 to bd23a4c Compare November 17, 2025 22:15
@yipin-chen yipin-chen requested a review from alexr-bq November 18, 2025 16:23
@currantw
Copy link
Collaborator Author

Steps for running locally:

brew install git-secrets
cd <ROOT_DIR>
git secrets --register-aws
git secrets --scan

Copy link
Collaborator

@xShinnRyuu xShinnRyuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIs are red.

@currantw currantw force-pushed the currantw/git-secrets branch from 7dbac4f to 2df5993 Compare November 20, 2025 18:10
Copy link
Collaborator

@affonsov affonsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@affonsov affonsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to be part of the pull request workflow

Change git-secrets workflow to trigger on pull_request events rather than
push events to main/release branches. This prevents secrets from being
merged rather than detecting them after the fact.

Addresses review feedback to catch secrets before merge.

Signed-off-by: currantw <[email protected]>
Signed-off-by: currantw <[email protected]>
@currantw currantw force-pushed the currantw/git-secrets branch from 2df5993 to a0e92cb Compare November 22, 2025 21:00
@currantw currantw merged commit 116eb05 into valkey-io:main Nov 25, 2025
23 of 25 checks passed
@currantw currantw deleted the currantw/git-secrets branch November 25, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants