-
Notifications
You must be signed in to change notification settings - Fork 21
added support for loading rdb/aof event #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sachinvmurthy
wants to merge
1
commit into
valkey-io:main
Choose a base branch
from
sachinvmurthy:update/loading_progress_event
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
added support for loading rdb/aof event #217
sachinvmurthy
wants to merge
1
commit into
valkey-io:main
from
sachinvmurthy:update/loading_progress_event
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
dmitrypol
reviewed
Nov 27, 2025
examples/server_events.rs
Outdated
| valkey_module! { | ||
| name: "srv_events", | ||
| version: 1, | ||
| version: 2, |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change version?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted
Collaborator
|
let's discuss more in-depth next week, have several questions |
dmitrypol
reviewed
Dec 1, 2025
dmitrypol
reviewed
Dec 1, 2025
dmitrypol
reviewed
Dec 1, 2025
dmitrypol
reviewed
Dec 1, 2025
40f6963 to
251cc3f
Compare
251cc3f to
e722a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds support for LoadingProgress event which is called repeatedly called while an RDB or AOF file is being loaded. The following sub events are available:
REDISMODULE_SUBEVENT_LOADING_PROGRESS_RDB
REDISMODULE_SUBEVENT_LOADING_PROGRESS_AOF
The data pointer can be casted to a RedisModuleLoadingProgress structure with the following fields:
int32_t hz; // Approximate number of events per second.
int32_t progress; // Approximate progress between 0 and 1024,
// or -1 if unknown.