Skip to content

Conversation

@sachinvmurthy
Copy link
Contributor

This PR Adds support for LoadingProgress event which is called repeatedly called while an RDB or AOF file is being loaded. The following sub events are available:

REDISMODULE_SUBEVENT_LOADING_PROGRESS_RDB
REDISMODULE_SUBEVENT_LOADING_PROGRESS_AOF

The data pointer can be casted to a RedisModuleLoadingProgress structure with the following fields:

int32_t hz; // Approximate number of events per second.
int32_t progress; // Approximate progress between 0 and 1024,
// or -1 if unknown.

@dmitrypol
Copy link
Collaborator

dmitrypol commented Nov 27, 2025

  • is there a way to run integration tests?
  • did you run cargo fmt

valkey_module! {
name: "srv_events",
version: 1,
version: 2,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

@dmitrypol
Copy link
Collaborator

let's discuss more in-depth next week, have several questions

@sachinvmurthy sachinvmurthy force-pushed the update/loading_progress_event branch 3 times, most recently from 40f6963 to 251cc3f Compare December 3, 2025 19:15
@sachinvmurthy sachinvmurthy force-pushed the update/loading_progress_event branch from 251cc3f to e722a6c Compare December 3, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants