Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Typeahead) highlight displays <strong> tag when empty spaces added at the end of query and does not escape html tags #6434

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

UdayAppam
Copy link
Contributor

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@UdayAppam UdayAppam changed the title Issue#4350 Issue#4350 Typeahead highlight displays <strong> tag when empty spaces added at the end of query and does not escape html tags Feb 17, 2022
@UdayAppam UdayAppam changed the title Issue#4350 Typeahead highlight displays <strong> tag when empty spaces added at the end of query and does not escape html tags fix(Typeahead) highlight displays <strong> tag when empty spaces added at the end of query and does not escape html tags Feb 17, 2022
@UdayAppam
Copy link
Contributor Author

#4350
Could you please review and if any suggestions open to discuss

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #6434 (f106c2b) into development (6be9fc4) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head f106c2b differs from pull request most recent head 2c54fb0. Consider uploading reports for the commit 2c54fb0 to get more accurate results

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6434      +/-   ##
===============================================
- Coverage        75.87%   75.86%   -0.02%     
===============================================
  Files              315      315              
  Lines            10642    10644       +2     
  Branches          2935     2936       +1     
===============================================
  Hits              8075     8075              
- Misses            2566     2568       +2     
  Partials             1        1              
Impacted Files Coverage Δ
src/typeahead/typeahead-container.component.ts 80.95% <100.00%> (+0.20%) ⬆️
src/chronos/i18n/sk.ts 85.00% <0.00%> (-2.50%) ⬇️
src/chronos/i18n/cs.ts 87.36% <0.00%> (-2.11%) ⬇️
src/chronos/i18n/pl.ts 85.24% <0.00%> (ø)
src/chronos/i18n/uk.ts 90.62% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6be9fc4...2c54fb0. Read the comment docs.

@cypress
Copy link

cypress bot commented Feb 17, 2022



Test summary

799 33 14 0


Run details

Project ngx-bootstrap
Status Failed
Commit 30347bc ℹ️
Started Mar 23, 2022 5:30 AM
Ended Mar 23, 2022 6:06 AM
Duration 35:52 💡
OS Linux Ubuntu - 20.04
Browser Electron 93

View run in Cypress Dashboard ➡️


Failures

datepicker/locales_spec.ts Failed
1 Datepicker demo testing suite: Locales > Change Locale Datepicker > when user chose locale es-pr for "Datepicker", container shown in appropriate language
2 Datepicker demo testing suite: Locales > Change Locale DateRangepicker > when user chose locale es-pr for "Daterangepicker", container shown in this language
typeahead_page_spec.ts Failed
1 Typeahead demo page testing suite > On blur > clicking anywhere outside auto-fills "Option on blur" with the first option from the matches list
modals_service_page_spec.ts Failed
1 Modals demo page testing suite: Service examples > Nested modals > when user clicks on the button "Open second modal" then the second modal with title "Second modal" is opened, "Close self" is present
2 Modals demo page testing suite: Service examples > Events > when user closes modal by click on the cross then should be messages "onHide event has been fired" and "onHidden event has been fired"
3 Modals demo page testing suite: Service examples > Events > when user closes modal by pressing ESC button then modal is closed and should be messages "onHide event has been fired" and "onHidden event has been fired"
4 Modals demo page testing suite: Service examples > Confirm Window > when user clicks on "Open modal" button then modal is opened, it contains two buttons: "Yes" and "No"
5 Modals demo page testing suite: Service examples > Custom css class > when user clicks on the cross button then the modal is closed
6 Modals demo page testing suite: Service examples > Animation option > when user clicks on the cross button then the modal is closed
7 Modals demo page testing suite: Service examples > Esc closing option > when user clicks on "Open modal" button then modal is opened. when user closes modal by click ESC button then modal stays opened
This comment includes only the first 10 test failures. See all 33 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@UdayAppam UdayAppam force-pushed the issue#4350 branch 4 times, most recently from c6d6da5 to 70bab72 Compare February 18, 2022 08:00
@UdayAppam
Copy link
Contributor Author

Hi @valorkin
Could you please review these changes.

…paces added at the end of query and does not escape html tags
@matthewfedak
Copy link

Is there any update to this issue? Can happily offer a reward to the person who gets this merged.

@rohanahata
Copy link

@valorkin can you please let us know if this can be merged?

@lexasq lexasq changed the base branch from development to 18-1-2-release-candidate October 17, 2024 15:13
@lexasq lexasq merged commit 0981da2 into valor-software:18-1-2-release-candidate Oct 17, 2024
10 checks passed
@lexasq lexasq mentioned this pull request Oct 17, 2024
5 tasks
lexasq added a commit that referenced this pull request Oct 21, 2024
* fix(Typeahead) Typeahead highlight displays <strong> tag when empty spaces added at the end of query and does not escape html tags (#6434)

Co-authored-by: udayk <[email protected]>
Co-authored-by: Alexey Umanskiy <[email protected]>

* fix(typeahead): rolled back changes from UdayAppam and introduced another solution

* update hr.ts (#6447)

change date separation from slashes (/) to dots (.)

Co-authored-by: Dmitriy Shekhovtsov <[email protected]>
Co-authored-by: Alexey Umanskiy <[email protected]>

* fix(chronos): fixed chronos test for updated croatian locale

* fix(bs-dropdown): state provided issue

* fix(daterange-picker): locale change fix

---------

Co-authored-by: UdayAppam <[email protected]>
Co-authored-by: udayk <[email protected]>
Co-authored-by: vrbaaa <[email protected]>
Co-authored-by: Dmitriy Shekhovtsov <[email protected]>
lexasq added a commit that referenced this pull request Oct 21, 2024
* fix(Typeahead) Typeahead highlight displays <strong> tag when empty spaces added at the end of query and does not escape html tags (#6434)

Co-authored-by: udayk <[email protected]>
Co-authored-by: Alexey Umanskiy <[email protected]>

* 18.1.2

* chore(version): version bump

* chore(version): version bump

* chore(version): version bump

---------

Co-authored-by: UdayAppam <[email protected]>
Co-authored-by: udayk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants