fix(modal): fixed the animation of closing the modal window (#6547) #6565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also fixes #6591 |
andy840119
reviewed
Aug 14, 2024
| @@ -141,7 +141,7 @@ export class BsModalService { | |||
| .provide({ provide: BsModalRef, useValue: bsModalRef }) | |||
| .attach(ModalContainerComponent) | |||
| .to('body'); | |||
| bsModalRef.hide = () => this.hide(bsModalRef.id); | |||
There was a problem hiding this comment.
Seems still have animate issue if user just called bsModalService?.hide(id); outside?
andy840119
added a commit
to hardcoretech/ngx-bootstrap-bs3
that referenced
this pull request
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.