Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore support for pre-Concurrency migrations #603

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Apr 27, 2024

These changes are now available in 1.48.1

Reverts and tweaks a few of the changes in the recent Sendable update in order to (hopefully) restore functionality for users still using legacy (pre-Concurrency) app entry points.

Fixes #602. (Hopefully.)

…nd less time locked when getting the migrators list in Migrator, remove a couple of spurious Sendable annotations.
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 25.01%. Comparing base (c4a406d) to head (f178cf6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #603   +/-   ##
=======================================
  Coverage   25.00%   25.01%           
=======================================
  Files         150      150           
  Lines        8569     8568    -1     
=======================================
  Hits         2143     2143           
+ Misses       6426     6425    -1     
Files Coverage Δ
Sources/FluentKit/Enum/EnumMetadata.swift 0.00% <0.00%> (ø)
Sources/FluentKit/Migration/Migrator.swift 0.00% <0.00%> (ø)
Sources/FluentKit/Migration/MigrationLog.swift 4.76% <0.00%> (ø)

@gwynne gwynne merged commit c4533db into main Apr 27, 2024
12 of 14 checks passed
@gwynne gwynne deleted the oldstyle-migration-fix-maybe branch April 27, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 1.48.0 successfully blocks execution of method try app.autoMigrate().wait()
2 participants