Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the MirrorBypass logic in Swift 6 #631

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Feb 18, 2025

These changes are now available in 1.50.3

It turns out that the "bypass" for Mirror works fine in Swift 6, so let's use it.

@gwynne gwynne added the semver-patch Internal changes only label Feb 18, 2025
@gwynne gwynne requested review from 0xTim, MahdiBM and ptoffy February 18, 2025 01:31
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 24.22%. Comparing base (dd5a92d) to head (4e7b44b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/FluentKit/Model/MirrorBypass.swift 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   24.28%   24.22%   -0.06%     
==========================================
  Files         149      149              
  Lines        9350     9348       -2     
==========================================
- Hits         2271     2265       -6     
- Misses       7079     7083       +4     
Files with missing lines Coverage Δ
Sources/FluentKit/Model/MirrorBypass.swift 76.19% <75.00%> (-6.89%) ⬇️

@gwynne gwynne merged commit 4f886eb into main Feb 18, 2025
16 checks passed
@gwynne gwynne deleted the mirror-bypass-swift-6 branch February 18, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants