Merged
Conversation
Notable changes are adding FMG data for ER DLC and AC6, and supporting clients connecting to multiple process names. As part of this, change DSMS and Smithbox to share the same port, which should be backwards compatible with the previous port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes are adding FMG data for ER DLC and AC6, and supporting clients connecting to multiple process names. As part of this, let DSMS and Smithbox share the same port 22720, as this would be simpler from client perspective if possible, as described in AinTunez/DarkScript3#21. Both should remain more-or-less compatible and ideally users shouldn't have to configure it, just use whichever one is open. Trying to automate things too much is maybe the root of this entire issue, but I hope this is reasonably simple enough.
Because of the process name lookup, this should be backwards compatible with any clients who were previously connecting to Smithbox at port 22721. If you'd prefer to keep the distinct ports, that would also be fine, and a third KnownServer could have both combined. I'll also update DSMS with whatever setup is preferable. Sorry that implementing this alternate approach took way too long after the DarkScript3 PR. Randomizer updates ended up taking over 3 months, and I didn't want to touch modding for a few weeks after that either.
Just to note this isn't a complete sync from soulsmods/SoapstoneLib. I left SoapstoneLib.csproj alone since Smithbox seems to have custom configuration there.