fix!(slice): array type def #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pront
force-pushed
the
pront/fix-slice-array-typedef
branch
from
bf63c1f to
9fc52a0
Compare
pront
force-pushed
the
pront/fix-slice-array-typedef
branch
from
9fc52a0 to
6f34875
Compare
jszwedko
reviewed
Feb 5, 2025
| @@ -1,5 +1,4 @@ | |||
| # result: { "array": { }, "array_unknown_infinite": { "object": { "foo": { "object": { "a": { "bytes": true, "integer": true } } } }, "undefined": true } } | |||
|
|
|||
| # result: { "array": { "0": { "object": { "foo": { "object": { "a": { "integer": true } } } } }, "1": { "object": { "foo": { "object": { "a": { "bytes": true } } } } } } } | |||
There was a problem hiding this comment.
Is this right? Why is there a 1 index too?
There was a problem hiding this comment.
If you expand the whole file:
a = []
a[0] = {"foo": {"a": 1}}
a[1] = {"foo": {"a": "bytes"}}
PS Just noticed the _x which looks like a no-op.
There was a problem hiding this comment.
Doh, I missed that there was more to this file 🤦
jszwedko
approved these changes
Feb 5, 2025
| @@ -1,5 +1,4 @@ | |||
| # result: { "array": { }, "array_unknown_infinite": { "object": { "foo": { "object": { "a": { "bytes": true, "integer": true } } } }, "undefined": true } } | |||
|
|
|||
| # result: { "array": { "0": { "object": { "foo": { "object": { "a": { "integer": true } } } } }, "1": { "object": { "foo": { "object": { "a": { "bytes": true } } } } } } } | |||
There was a problem hiding this comment.
Doh, I missed that there was more to this file 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
our guidelines.
Checklist
run
dd-rust-license-tool writeand commit the changes. More details here.References
slicecauses loss of type information #363 (comment)