fix(mcp): Chain MCP lifespan with FastAPI app lifespan #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MCP server's lifespan was not being properly chained with the FastAPI app's lifespan, causing the MCP server to not start/stop correctly when mounted as a sub-application. Changes: - Create MCP app before FastAPI app to access its lifespan - Chain MCP lifespan context with FastAPI's lifespan context - Ensures MCP server lifecycle is properly managed This fix is required for the MCP server to function correctly when used with Claude Code and other MCP clients. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
Author
|
Needed to make this change for MCP in CC to work. |
nicoloboschi
approved these changes
Jan 1, 2026
Collaborator
nicoloboschi
left a comment
nicoloboschi
left a comment
There was a problem hiding this comment.
LGTM
we need to an integration test for MCP before cutting the next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the MCP server lifespan not being properly chained with the FastAPI app's lifespan, causing the MCP server to not start/stop correctly when mounted as a sub-application.
Problem
When the MCP server is mounted as a sub-application, its lifespan context was not being invoked, causing initialization issues.
Solution
asynccontextmanagerTesting
Verified with Claude Code MCP integration - the server now starts and stops correctly.