Skip to content

ci: use Anthropic WIF in smoke-test workflow - #21

Closed
Nemo157 wants to merge 1 commit into
mainfrom
wim/push-ynzxvovsuqlv
Closed

Nemo157 wants to merge 1 commit into
mainfrom
wim/push-ynzxvovsuqlv

Conversation

@Nemo157

@Nemo157 Nemo157 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Replace the ANTHROPIC_API_KEY secret in claude-chiplab-smoke.yml with claude-code-action's Workflow Identity Federation inputs.

@Nemo157
Nemo157 requested a review from forria64 October 20, 2026 14:31
@claude

This comment has been minimized.

@Nemo157 Nemo157 changed the title Use Anthropic workload identity federation in smoke-test workflow ci: use Anthropic WIF in smoke-test workflow Oct 20, 2026
Replace the `ANTHROPIC_API_KEY` secret in `claude-chiplab-smoke.yml`
with `claude-code-action`'s Workflow Identity Federation inputs.
@Nemo157
Nemo157 force-pushed the wim/push-ynzxvovsuqlv branch from d96f470 to 55683ed Compare October 20, 2026 14:40
@Nemo157

This comment has been minimized.

@claude

claude Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Change Summary

Replaces the ANTHROPIC_API_KEY secret in .github/workflows/claude-chiplab-smoke.yml with the three claude-code-action workload identity federation inputs, read from ANTHROPIC_ORGANIZATION_ID, ANTHROPIC_CHIPLAB_SMOKE_FEDERATION_RULE_ID and ANTHROPIC_CHIPLAB_SMOKE_SERVICE_ACCOUNT_ID.
Header, permissions and step comments are updated to describe the OIDC exchange and the job_workflow_ref claim the federation rule must trust.
No issue reference is given in the PR or commit.

Both points from the previous review are addressed: the commit now carries the ci: conventional-commit prefix, and the ANTHROPIC_ORGANIZATION_ID comment now reads (shared org variable).
The input names match the ones forwarded by veecle/style-guide's claude-review action, the job_workflow_ref value is correct for a non-reusable workflow triggered by issue_comment on the default branch, and no other file in the repo references ANTHROPIC_API_KEY.

✅ Review complete - no new issues found

@Nemo157
Nemo157 requested a review from luchhh October 21, 2026 08:08
# Secrets required:
# CHIPLAB_API_KEY - API token for Chiplab MCP authentication (veecle_pat_*)
# ANTHROPIC_API_KEY - Anthropic API key used by claude-code-action
# CHIPLAB_API_KEY - API token for Chiplab MCP authentication (veecle_pat_*)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is meant to be used as a CI template for users and probably we will raise the barrier to entry with this change. Could we keep WIF for our CI but show anthropic_api_key as a commented-out alternative?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmm, true. What I could do here is switch over to just a service account API key instead, that seems good enough for this workflow.

@Nemo157 Nemo157 closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants