Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify json.config to contain the content of configuration.h #162

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

royfalk
Copy link
Contributor

@royfalk royfalk commented Mar 4, 2025

Match of engine/1052

Please answer the following:

Code Changes:

  • See engine PR

Issues:

  • See engine PR

@royfalk royfalk marked this pull request as draft March 4, 2025 02:38
@royfalk royfalk self-assigned this Mar 4, 2025
"introduction": "Welcome to Vega Strike!\nUse #8080FFTab#000000 to afterburn (#8080FF+,-#000000 cruise control),\n#8080FFarrows#000000 to steer.\nThe #8080FFt#000000 key targets objects; #8080FFspace#000000 fires at them & #8080FFa#000000 activates the SPEC drive.\nTo go to another star system, buy a jump drive for about 10000 credits,\nfly to a wireframe jump-point and press #8080FFj#000000 to warp to a near star.\nTarget a base or planet;\nWhen you get close a green box will appear. Inside the box, #8080FFd#000000 will land."
},
"advanced": {}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing line break (LF) at end of file

Copy link
Contributor

@stephengtuggy stephengtuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from the one missing line break, which isn't a blocker.

Please note that configuration.h didn't contain all the settings yet, so this file probably doesn't either. But it's a good start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants