fix(eve): skip nested git repos in dev snapshots#589
Closed
iroiro147 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
Contributor
|
@iroiro147 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #526.
eve devsource snapshots now stop recursing when a copied child directory contains its own.gitfile or directory. That treats nested repositories, submodules, and git worktrees as source-copy boundaries without special-casing.claude/worktrees.This keeps ordinary sibling content copied as before while avoiding duplicate checkout copies inside dev-runtime snapshots.
How did you test your changes?
pnpm --filter eve exec vitest run --config vitest.integration.config.ts src/internal/nitro/dev-runtime-artifacts.integration.test.ts -t 'nested git|generated output'\n-pnpm --filter eve run typecheck\n-pnpm --filter eve exec oxlint src/internal/nitro/dev-runtime-source-snapshot-copy.ts src/internal/nitro/dev-runtime-artifacts.integration.test.ts\n-pnpm exec oxfmt --check packages/eve/src/internal/nitro/dev-runtime-source-snapshot-copy.ts packages/eve/src/internal/nitro/dev-runtime-artifacts.integration.test.ts .changeset/dev-snapshot-nested-git-boundaries.md\n-pnpm guard:invariants\n-pnpm changeset status --since origin/main\n-git diff --check\n\nNote:pnpm --filter eve run test:integration -- src/internal/nitro/dev-runtime-artifacts.integration.test.ts -t 'nested git|generated output'expands to the full integration suite in this repo and hit an unrelated locallisten EPERMinsrc/client/client.integration.test.ts; the tier-configured touched-file command above passed.\n\n### PR Checklist\n\n- [x] I linked an issue with prior discussion confirming this change is wanted\n- [x] I ran the relevant checks from CONTRIBUTING.md\n- [x] I added tests and documentation where relevant\n- [x] I added a changeset if this touches the publishedevepackage\n- [x] DCO sign-off passes for every commit (git commit --signoff)\n