Skip to content

fix(github): compose channel event handlers#642

Open
iroiro147 wants to merge 1 commit into
vercel:mainfrom
iroiro147:fix/channel-event-composition-623
Open

fix(github): compose channel event handlers#642
iroiro147 wants to merge 1 commit into
vercel:mainfrom
iroiro147:fix/channel-event-composition-623

Conversation

@iroiro147

Copy link
Copy Markdown
Contributor

Summary

  • add composable channel event helpers (afterDefault, beforeDefault, replaceDefault) to the public eve/channels surface
  • make GitHub channel events compose after built-in handlers by default, so custom status handlers do not disable checkout, replies, or failure comments unless replacement is explicit
  • document the GitHub event composition contract and add regression coverage for default reply, checkout preservation, and explicit replacement

Refs #623.

Tests

  • pnpm --filter eve exec vitest run --config vitest.unit.config.ts src/public/channels/github/githubChannel.test.ts
  • pnpm --filter eve run typecheck
  • pnpm exec oxfmt --check packages/eve/src/public/definitions/channel.ts packages/eve/src/public/channels/index.ts packages/eve/src/public/channels/github/githubChannel.ts packages/eve/src/public/channels/github/defaults.ts packages/eve/src/public/channels/github/githubChannel.test.ts docs/channels/github.mdx .changeset/channel-event-composition.md
  • pnpm exec oxlint --deny-warnings packages/eve/src/public/definitions/channel.ts packages/eve/src/public/channels/index.ts packages/eve/src/public/channels/github/githubChannel.ts packages/eve/src/public/channels/github/defaults.ts packages/eve/src/public/channels/github/githubChannel.test.ts
  • pnpm docs:check
  • pnpm guard:invariants
  • git diff --check
  • pnpm changeset status --since origin/main

Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@iroiro147 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant