Skip to content

fix(dev-runtime): honor gitignore in snapshots#658

Open
iroiro147 wants to merge 1 commit into
vercel:mainfrom
iroiro147:fix/dev-snapshot-gitignore-652
Open

fix(dev-runtime): honor gitignore in snapshots#658
iroiro147 wants to merge 1 commit into
vercel:mainfrom
iroiro147:fix/dev-snapshot-gitignore-652

Conversation

@iroiro147

@iroiro147 iroiro147 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • honor app .gitignore entries while copying dev-runtime source snapshots
  • scope .gitignore matching to the app root so app build ignores do not drop required workspace package artifacts
  • keep the existing built-in snapshot skips, upstream nested-git boundary skip, and app-root build/dist skips intact
  • add integration regressions for ignored vector-store data, negation, nested file skips, and linked workspace package dist preservation

Tests

  • pnpm --filter eve run build:js
  • pnpm --filter eve exec vitest run --config vitest.integration.config.ts src/internal/nitro/dev-runtime-artifacts.integration.test.ts
  • pnpm exec oxlint packages/eve/src/internal/nitro/dev-runtime-source-snapshot-copy.ts packages/eve/src/internal/nitro/dev-runtime-artifacts.integration.test.ts
  • pnpm exec oxfmt --check packages/eve/src/internal/nitro/dev-runtime-source-snapshot-copy.ts packages/eve/src/internal/nitro/dev-runtime-artifacts.integration.test.ts .changeset/tame-lance-snapshots.md
  • git diff --check -- packages/eve/src/internal/nitro/dev-runtime-source-snapshot-copy.ts packages/eve/src/internal/nitro/dev-runtime-artifacts.integration.test.ts .changeset/tame-lance-snapshots.md

Refs #652

@vercel

vercel Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@iroiro147 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@iroiro147 iroiro147 force-pushed the fix/dev-snapshot-gitignore-652 branch from 75ad0c8 to 544f2e0 Compare July 9, 2026 17:56
Comment on lines +366 to +367
}

@vercel vercel Bot Jul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitIgnorePatternToRegExp mishandles ** because it emits the adjacent / separator literally, so leading/mid **/ patterns require at least one directory segment and fail to match top-level entries.

Fix on Vercel

Signed-off-by: iroiro147 <sarthak.singh@juspay.in>
@iroiro147 iroiro147 force-pushed the fix/dev-snapshot-gitignore-652 branch from 544f2e0 to f09ef26 Compare July 9, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant