-
Notifications
You must be signed in to change notification settings - Fork 1.3k
deps: upgrade playwright version #4186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
cd56338 to
be29905
Compare
be29905 to
426e981
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 Build Fix:
The Vercel project configuration was pointing to a non-existent "docs" directory as the root build directory. Adding vercel.json with "root": "." tells Vercel to build from the repository root where the actual source code and build configuration are located.
View Details
📝 Patch Details
diff --git a/vercel.json b/vercel.json
new file mode 100644
index 0000000..938fa64
--- /dev/null
+++ b/vercel.json
@@ -0,0 +1,3 @@
+{
+ "root": "."
+}
Analysis
Missing Vercel root directory configuration causes build failure
What fails: Vercel deployment fails because the project is configured to use "docs" as the root directory, but that directory does not exist in the repository.
How to reproduce:
# Attempt to deploy with Vercel using the dep/playwright branch
# The build will fail with: "The specified Root Directory "docs" does not exist. Please update your Project Settings."Result:
The specified Root Directory "docs" does not exist. Please update your Project Settings.
Expected behavior: Vercel should build the project from the repository root (the current directory) where the package.json, source code, and build configuration files are located.
Solution: Added a vercel.json configuration file with "root": "." to explicitly tell Vercel to use the repository root as the build directory, overriding any project-level configuration that was incorrectly set to "docs".
the playwright version we used is deprecated now.
based on #4184 #4185