chore(signals): prefactor #9995
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
NicholasLYang
approved these changes
Feb 25, 2025
| edition = "2021" | ||
|
|
||
| [dependencies] | ||
| futures = "0.3.30" |
There was a problem hiding this comment.
Any particular reason we're using a different version for futures instead of the workspace root version?
Comment on lines
+151
to
+154
| #[cfg(windows)] | ||
| const DEFAULT_SIGNAL: Signal = Signal::CtrlC; | ||
| #[cfg(not(windows))] | ||
| const DEFAULT_SIGNAL: Signal = Signal::Interrupt; |
There was a problem hiding this comment.
Nit, but we could do and avoid the conditional compilation
Suggested change
| #[cfg(windows)] | |
| const DEFAULT_SIGNAL: Signal = Signal::CtrlC; | |
| #[cfg(not(windows))] | |
| const DEFAULT_SIGNAL: Signal = Signal::Interrupt; | |
| const DEFAULT_SIGNAL: Signal = if cfg!(windows) { Signal::CtrlC } else {Signal::Interrupt }; |
|
|
||
| #[cfg(windows)] | ||
| /// A listener for Windows Console Ctrl-C events | ||
| pub fn get_signal() -> Result<impl Stream<Item = Option<Signal>>, std::io::Error> { |
There was a problem hiding this comment.
Minor detail, but maybe we should make this a custom error type so we can annotate the run::Error type with #[from] and avoid having to use map_err when calling this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prefactors:
PR that prefactors the signals code to prepare for:
turboThere are no behavior changes in this PR. I highly suggest reviewing each commit on its own.
Testing Instructions
Existing unit tests.
Quick manual verification that existing
SIGINTbehavior remains the same: