Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
scotttrinh
force-pushed
the
regression-tests
branch
from
20ecb3c to
f4d77d3
Compare
scotttrinh
force-pushed
the
regression-tests
branch
from
f4d77d3 to
6dd4080
Compare
scotttrinh
force-pushed
the
regression-tests
branch
from
6dd4080 to
2623056
Compare
scotttrinh
commented
Feb 6, 2026
| slug: str | None = None, | ||
| base_url: str = DEFAULT_API_BASE_URL, | ||
| timeout: float = 30.0, | ||
| timeout: float = DEFAULT_TIMEOUT, |
Collaborator
Author
There was a problem hiding this comment.
This is an actual behavioral change that is intentional. Someone flag if there is a reason why the async version uses DEFAULT_TIMEOUT (which is 60 seconds) and the sync version uses 30 seconds.
Collaborator
Author
|
Closing for now as it's part of #48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is extracted from #44 since we might actually go a different way, but this regression test suite is a nice thing to keep and base other attempts at no-op refactors on.