feat(core): experimental start-hook admission for start()#2762
Draft
NathanColosimo wants to merge 1 commit into
Draft
feat(core): experimental start-hook admission for start()#2762NathanColosimo wants to merge 1 commit into
NathanColosimo wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: c413943 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
This was referenced Jul 2, 2026
NathanColosimo
force-pushed
the
nathan/start-hooks-01-core
branch
from
79beb9d to
41bdb5a
Compare
NathanColosimo
force-pushed
the
nathan/start-hooks-01-core
branch
from
8438b93 to
7916e94
Compare
NathanColosimo
force-pushed
the
nathan/start-hooks-01-core
branch
from
7916e94 to
f2c69fc
Compare
Adds the experimentalStartHook option to start(): Worlds that declare experimentalStartHookAdmission (event-first or queue-first) reserve the hook token atomically with run admission. Duplicate starts throw HookConflictError; queue-first Worlds throw the new WorkflowStartError (runId/stage/retryable) when a run was queued but admission could not be confirmed. Turbo mode is disabled for start-hook runs and a queued run that lost its claim acknowledges without running user code, gated by the experimentalStartHookLoserAck capability. world-vercel's v4 wire routing carries the new run_created / resilient-start eventData field (its compile-time wire-contract guard requires schema fields to be routed in the same change); the Vercel admission behavior itself, and the local/postgres implementations, land in the stacked follow-ups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 1/4 · this PR → #2763 → #2764 → #2765 · Replaces the monolithic #2684
Adds the experimental
hookoption tostart()(refs #2376, gaps 1 and 2): Worlds that declarestartHookAdmissionreserve the hook token atomically with run admission, so duplicate starts are rejected before any duplicate workflow code can run.What's in this PR
start()option + validation. Admission is queue-first everywhere: enqueue → admission (run_createdclaims the token). A crash after the enqueue cannot orphan a claimed token — the queued message bootstraps admission itself via the resilientrun_startedpath. Admission failures after the enqueue surface as the newWorkflowStartError(runId/stage/queued/retryable);HookConflictErrorpasses through.experimental_ttlis optional: without it, the token is released when the hook is disposed or the run ends (plain-guard semantics); with it, the token stays fenced for the TTL past hook creation / run completion.start()path are now also typed asWorkflowStartError(stagequeue) instead of leaking raw transport errors — the create/queue parallelism is unchanged.startHookLoserAckcapability (cutoff5.0.0-beta.27).@workflow/world:World.startHookAdmissiondeclaration,StartHookschema/type onrun_created/ resilient-startrun_started/ queuerunInput(embedded directly in the queue runInput schema).WorkflowStartErrorserialization end-to-end (core reducers/revivers, web-shared + CLI hydration).start()API notes,WorkflowStartErrorreference page.No World in this PR implements admission yet — using the option against an unsupporting World throws a clear error. Implementations land in the stacked follow-ups.
Docs Preview
Preview links will resolve once the docs deployment builds for this branch:
/v5/docs/foundations/idempotency#atomic-start-hook-idempotency,/v5/docs/api-reference/workflow-api/start,/v5/docs/api-reference/workflow-errors/workflow-start-error.