[core] Rename experimental_setAttributes to setAttributes#2882
Conversation
The attributes feature is no longer experimental. The old experimental_setAttributes export remains as a deprecated alias. Docs page moved to api-reference/workflow/set-attributes with redirects from the old URL. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: ee88cbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
📊 Workflow Benchmarkscommit Backend:
Avg deltas compare against the most recent benchmark run on Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader) Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges 🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120 TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request. |
TooTallNate
left a comment
There was a problem hiding this comment.
Clean graduation rename. No blocking issues.
Changes reviewed (23 files, +201/-162):
- Deprecated aliases done right:
export const experimental_setAttributes = setAttributeswith@deprecatedJSDoc in BOTH entrypoints (host-sidecore/src/set-attributes.tsand workflow-VMcore/src/workflow/set-attributes.ts), plusExperimentalSetAttributesOptions = SetAttributesOptionstype alias. Existing code keeps compiling and gets editor deprecation hints. Unit tests cover the alias. - Docs: API reference page renamed with permanent redirects in
next.config.tscovering both the versioned (/v5/...) and unversioned paths — the comment explaining the unversioned path matters once v5 becomes default is a nice touch. The old-name callout on the new page helps people landing from stale links/snippets. - Consistency sweep: error messages, doc comments, workbench e2e workflows, and the Observability → Attributes page (experimental callout dropped, "Experimental Behavior" → "Behavior") all updated.
- Changesets:
minorfor@workflow/core+workflow(new export),patchfor@workflow/world(doc comments only). Correct semver classification.
All CI green. LGTM.
|
No backport to This commit renames the To override, re-run the Backport to stable workflow manually via |
Summary
The attributes feature is no longer experimental, so the
experimental_setAttributesexport is renamed tosetAttributes.setAttributesis now exported fromworkflow(both the host-side and workflow-VM entrypoints), along with theSetAttributesOptionstype.experimental_setAttributes(and theExperimentalSetAttributesOptionstype) remain as deprecated aliases so existing code keeps working; they will be removed in a future release.Docs
api-reference/workflow/experimental-set-attributestoapi-reference/workflow/set-attributes, with permanent redirects for the old URL (both versioned and unversioned paths).startand theworkflowpackage index were updated.🤖 Generated with Claude Code
Docs Preview