Allow methodcall and new to access interface arrays #5973
+77
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnment should not be a non-virtual interface.
wsnyder
reviewed
May 2, 2025
|
Let me know when ready for another review - first click "resolved" on above, remove commented-out code, and do a "make format" please. |
|
This should be ready for another review, I'm slightly surprised that 'make format' has apparently run itself! |
wsnyder
reviewed
May 11, 2025
src/V3Inst.cpp
Outdated
| // copy between arrays | ||
| if (!VN_IS(lhsarrp->subDTypep()->skipRefp(), IfaceRefDType)) return; | ||
| if (!VN_IS(rhsarrp->subDTypep()->skipRefp(), IfaceRefDType)) return; | ||
| if (VN_AS(rhsarrp->subDTypep()->skipRefp(), IfaceRefDType)->isVirtual()) | ||
| return; | ||
| if (!VN_AS(lhsarrp->subDTypep()->skipRefp(), IfaceRefDType)->isVirtual()) { | ||
| nodep->lhsp()->v3error("Illegal target of assignment"); |
There was a problem hiding this comment.
Illegal or unsupported? Can it turn up if something unexpected like a queue is involved? Add the types to the error so more obvious? (prettyDTypeNameQ())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle de-array case so that new and methods can access interfaces from an array.