Skip to content

Commit 7d0006e

Browse files
[CI] Fix CPP Format Issue
The format test for CPP was not working on the CI; however, the scripts that the CI uses work locally. I believe the issue is caused by the make format target relying on Python and due to recent cleanups, we specifically do not build python for this test. I think that the make format call was failing which was not raising any errors or warnings.
1 parent aec8907 commit 7d0006e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ jobs:
128128
fail-fast: false
129129
matrix:
130130
include:
131-
- { name: 'C/C++', script: 'check-format.sh' , with_python: 'no', pkgs: 'clang-format-18' }
131+
- { name: 'C/C++', script: 'check-format.sh' , with_python: 'yes', pkgs: 'clang-format-18' }
132132
- { name: 'Python', script: 'check-format-py.sh', with_python: 'yes', pkgs: '' }
133133
- { name: 'Python Lint', script: 'pylint_check.py' , with_python: 'yes', pkgs: '' }
134134
name: 'F: ${{ matrix.name }}'

0 commit comments

Comments
 (0)