Fix bug with checking if device has interposer cuts

Author: AmirhosseinPoolad

libs/libarchfpga/src/device_grid.cpp

@@ -89,3 +89,21 @@ void DeviceGrid::count_instances() {
         }
     }
 }
+
+bool DeviceGrid::has_interposer_cuts() const {
+    bool has_cuts = false;
+
+    for (const std::vector<int>& layer_h_cuts : horizontal_interposer_cuts_) {
+        if (!layer_h_cuts.empty()) {
+            has_cuts = true;
+        }
+    }
+
+    for (const std::vector<int>& layer_v_cuts : vertical_interposer_cuts_) {
+        if (!layer_v_cuts.empty()) {
+            has_cuts = true;
+        }
+    }
+
+    return has_cuts;
+}

libs/libarchfpga/src/device_grid.h

@@ -211,6 +211,11 @@ class DeviceGrid {
         return vertical_interposer_cuts_;
     }
 
+    /// Returns if the grid has any interposer cuts. You should use this function instead of
+    /// checking if get_horizontal/vertical_interposer_cuts is empty, since the return value
+    /// of those functions might look something like this: {{}} which is technically not empty.
+    bool has_interposer_cuts() const;
+
   private:
     /// @brief Counts the number of each tile type on each layer and store it in instance_counts_.
     /// It is called in the constructor.

vpr/src/route/rr_graph_generation/rr_graph.cpp

@@ -1670,7 +1670,7 @@ static std::function<void(t_chan_width*)> alloc_and_load_rr_graph(RRGraphBuilder
     }
 
     // If there are any interposer cuts, remove the edges and shorten the wires that cross interposer cut lines.
-    if (!grid.get_horizontal_interposer_cuts().empty() || !grid.get_vertical_interposer_cuts().empty()) {
+    if (grid.has_interposer_cuts()) {
         std::vector<RREdgeId> interposer_edges = mark_interposer_cut_edges_for_removal(rr_graph, grid);
         rr_graph_builder.remove_edges(interposer_edges);