Update install.sh for release 2026.4.1-preview.3#36
Conversation
- Sync installer script with latest version - Automated update from release workflow
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a276794d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ -w "$INSTALL_DIR" ]; then | ||
| cp "${TEMP_DIR}/vvctl" "${INSTALL_DIR}/vvctl" | ||
| else | ||
| sudo cp "${TEMP_DIR}/vvctl" "${INSTALL_DIR}/vvctl" |
There was a problem hiding this comment.
The new install branch checks -w "$INSTALL_DIR" and immediately copies, but it no longer creates the directory first. When INSTALL_DIR is set to a path that does not yet exist (for example INSTALL_DIR=$HOME/bin), the writability test is false and the script falls back to sudo cp, which still fails because the parent directory is missing (and may also fail on systems without sudo). This is a regression from the previous behavior (mkdir -p) and breaks valid custom install targets.
Useful? React with 👍 / 👎.
1 participant
Automated update of install.sh for release 2026.4.1-preview.3
This PR updates the installer script to sync with the latest version from the main repository.
Changes include: