Update install.sh for release 2026.4.2#38
Conversation
- Sync installer script with latest version - Automated update from release workflow
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e673536b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ -w "$INSTALL_DIR" ]; then | ||
| cp "${TEMP_DIR}/vvctl" "${INSTALL_DIR}/vvctl" | ||
| else | ||
| sudo cp "${TEMP_DIR}/vvctl" "${INSTALL_DIR}/vvctl" |
There was a problem hiding this comment.
The install step now copies directly into INSTALL_DIR without ensuring the directory exists, so installs fail with No such file or directory when users set INSTALL_DIR to a new path (or on minimal systems where /usr/local/bin is absent). In those cases both branches fail (cp and sudo cp), which is a regression from the previous behavior that created the directory first.
Useful? React with 👍 / 👎.
1 participant
Automated update of install.sh for release 2026.4.2
This PR updates the installer script to sync with the latest version from the main repository.
Changes include: