This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
ProxyAuthenticator enhancements #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Did we have to bump the build version number? |
What do you mean? We are using |
|
I'll create the same PR for adamfisk/LittleProxy to substitute adamfisk#356 and adamfisk#351. I don't see any activity/comments of those PRs however ( |
k-sever
force-pushed
the
proxy-authenticator-enhancements
branch
from
d989146 to
ed2e3f5
Compare
|
Let's not merge this one for now : https://github.com/verygoodsecurity/vault/issues/1006#issuecomment-293687869 |
This was referenced Apr 12, 2017
|
@k-sever can we merge this? |
…onHeader and HttpRequest
zdmytriv
force-pushed
the
proxy-authenticator-enhancements
branch
from
ed2e3f5 to
755e606
Compare
|
[ch2260] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed ProxyAuthenticator to be more generic. It accepts AuthorizationHeader and HttpRequest
Repack of #3 and #4