WIP: Upgrade test #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is where I noticed we never test upgrades
miketwo
commented
Sep 8, 2024
Owner
|
It turns out |
Owner
|
I'm pretty stupid |
Owner
|
|
Collaborator
Author
|
I've been coding since 1987 and I still make mistakes like that. (It gets worse when you know 10+ languages - I can't keep anything straight.) That's why I test so much. Fixes everything. |
Owner
|
wonder if i can use regex to make this faster |
Collaborator
Author
Definitely. You could do something like: |
Owner
|
I now hate vim regex |
Owner
|
|
vesper-arch
approved these changes
Sep 15, 2024
Collaborator
Author
|
Huzzah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test that calls
upgrade()on all cards. Lots of failures. I could use some help fixing them all.