Updated gitignore #85
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed poetry.lock (should be created automatically) added poetry.lock to .gitignore removed unused stuff from .gitignore
|
Some of these I do have to use. pyright settings I have as well as the virtual environment directories. Probably some other stuff I'll have to check later |
|
Unit test stuff also is needed I think |
miketwo
requested changes
Dec 8, 2024
| # C extensions | ||
| *.so | ||
| # ignore poetry lock file - created automatically | ||
| poetry.lock |
There was a problem hiding this comment.
Poetry recommends committing the lockfile to get more reproducible builds. It makes it so that when dependencies are installed, the exact ones are used for different developers.
Comment on lines
-39
to
-54
| # Unit test / coverage reports | ||
| htmlcov/ | ||
| .tox/ | ||
| .nox/ | ||
| .coverage | ||
| .coverage.* | ||
| .cache | ||
| nosetests.xml | ||
| coverage.xml | ||
| *.cover | ||
| *.py,cover | ||
| .hypothesis/ | ||
| .pytest_cache/ | ||
| cover/ | ||
| pytest-coverage.txt | ||
| pytest.xml |
There was a problem hiding this comment.
All of these are good to have because the repo has unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed poetry.lock (should be created automatically) added poetry.lock to .gitignore
removed unused stuff from .gitignore