makes ice better at chilling drinks#39023
makes ice better at chilling drinks#39023CrazyAmphibian wants to merge 5 commits intovgstation-coders:Bleeding-Edgefrom
Conversation
|
thank you coders very cool |
Sorry chud, no fun allowed |
|
Does dispenser ice/vendor ice start at 0°C? If so the issue doesn't exist. Else, please make it so. |
|
yep, both seem to start at 0C |
| var/allowed_consumption = ( holder.chem_temp - required_temp )/50 //.1 units used for every 5 degrees | ||
| allowed_consumption = ceil(allowed_consumption*10)/10 //clamp to every .1 units. | ||
| allowed_consumption = min(allowed_consumption,created_volume) //limit to how many units we have to work with. | ||
| holder.chem_temp = max(T0C,holder.chem_temp-allowed_consumption*10) //each .1 unit reduces the temp by 1 degree. |
There was a problem hiding this comment.
not taking into account specific heat
There was a problem hiding this comment.
not taking into account specific heat
We don't even take enthalpy of fusion into account, our chemistry system is as barebones as can be. This approximation, while not realistic, would match the FEEL of ice taking a lot of heat to melt. (For reference, you need about 300kJ to melt 1kg of ice at 0°C into water at 0°C, heating that same water at 0°C to 100°C is about 400kJ, the transition to vapor costs around 2000kJ. Meaning that JUST MELTING the ice into water costs almost as much energy as it'd take to heat it to a boil).
We COULD add an enthalpy subsystem for phase transitions such as ice to water to steam, or liquid oxygen to atmospheric oxygen, etc, but that's way out of scope for this PR (it WOULD be cool (heh) to have).
There was a problem hiding this comment.
stop ideasguying, ideasguy
There was a problem hiding this comment.
i don't care if you set the cooling rate to 999999kj per unit ice melted, but i think the liquids' specheat should be taken into account
if every way to heat/cool reagents used flat increases, why even fuck around with the specific heat in the first place?
There was a problem hiding this comment.
stop ideasguying, ideasguy
It's not an ideaguys post, it's arguing that we don't have a phase transition system, so your wack ass approximation, while unrealistic, is closer to how ice behaves irl and feels about right.
The man does have a point however, why even have specheats if you're just fucking around with flat increases.
There was a problem hiding this comment.
i dunno ask the guy who coded them in. i don't play chemist, but from my observations looking at recipes and whatnot is that it's largely a pointless system that's only used for making some reagents more of a pain in the ass to work with, and making TEG lubing not suck.
most of our reagents have very similar capacities anyways, besides the 2 that have massive ones for the purpose of heating incredibly slowly
There was a problem hiding this comment.
While I agree that getting too in the weeds with physics realism gets us things like hinafire, this change trivializes cooling reagents. We already rarely see the chem heating/cooling machines used and this will just further the problem. Unfortunately factoring in the specific heat here would, indeed, solve this issue. The other solution here could be to just limit this to juices, drinks, cocktails, cocktail mixers, etc so nerds don't steal the barman shaker to powergame their cold chems.
There was a problem hiding this comment.
alright i accounted for SHC. the cooling rate will be the same for water (and similar capacity liquids) hope this is satisfactory.
[tweak]
What this does
makes it so that instead of melting all at once, ice gradually melts into water, and cools down the reagents it's in.
also makes ice begin to melt at 10C (formerly 25C). this is to allow ice to cool down room temperature drinks in the melting process.
ice will not melt if it's in a shaker, or if the reagent container is inside of a chem dispenser (booze dispenser counts). this is to prevent ice melting while you're making a drink that may use it.
Why it's good
cold drinks are better, from my experience. also MUH IMMULSIONS ice doesn't melt all at once. gives ice a bit more of a use case other than just drink mixing
How it was tested
went into a hot room and observed the drink stay cool and the ice slowly melt
Changelog
🆑