Normal and reinforced wall sprite refactor#39056
Open
SECBATON-GRIFFON wants to merge 33 commits intovgstation-coders:Bleeding-Edgefrom
Open
Normal and reinforced wall sprite refactor#39056SECBATON-GRIFFON wants to merge 33 commits intovgstation-coders:Bleeding-Edgefrom
SECBATON-GRIFFON wants to merge 33 commits intovgstation-coders:Bleeding-Edgefrom
Conversation
Collaborator
|
You should clarify on the title and with BIG LETTERSon the OP itself that this is largely just a backend optimization, and that the only actual change is that partially deconstructed rwalls will keep the smoothing. |
Contributor
Author
that's what a refactor means |
Collaborator
|
You'd be surprised at how many people don't really read the PR and just vibe it out or skim through. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[sprites]
What this does
Cuts down tons of sprites in the .dmi by turning the junction sprites and wall reinforcement into overlays.
Currently only for walls, reinforced walls, and anything sharing the icons such as falsewalls.
Why it's good
Makes deconstructing reinforced walls have smoothing, as seen above.
How it was tested
Loading into test_tiny and deconstructing some of the reinforced walls, spawning a reinforced falsewall, opening and closing it, viewing the falsewall on mesons.
Changelog
🆑