APP-6309: restrict text in Firefox in <RestrictedText> input
#581
+13
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
changed the title
<RestrictedText> input
ethanlook
approved these changes
Sep 20, 2024
mcous
force-pushed
the
APP-6309/mcous/move-bind
branch
from
7c30163
to
4328a40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fun bug! In Firefox, the
<RestrictedText>input does not restrict text:I traced this to a race-condition in out
<Input>component due to its usage ofbind. Theon:inputhandler was setting the value to the restricted text, but then Svelte was coming in and setting the value back to an out-of-date value thanks to thebind. Very silly.Change log
bind:valuebelowon:inputevent in<Input>to ensure input event handlers take priorityReview requests
<RestrictedText>should restrict text in the playground and docs site