RSDK-8790: Add frame_rate to Go SDK #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
randhid
requested changes
Sep 23, 2024
There was a problem hiding this comment.
A few nits, generally looking really good! You will need to bump the api version once your API change is merged into the API repo. Also, because none of the cameras broke, modules should not break either. Caveat: this is true for python and go, I don't see a reason for an additive change to break a C++ module, but we'll keep an eye on the intelrealsense when we bump the sdk version there.
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
hexbabe
approved these changes
Sep 23, 2024
viambot
added
safe to test
viambot
added
safe to test
seanavery
approved these changes
Sep 23, 2024
| @@ -316,6 +316,11 @@ func (c *client) Properties(ctx context.Context) (Properties, error) { | |||
| } | |||
| result.MimeTypes = resp.MimeTypes | |||
| result.SupportsPCD = resp.SupportsPcd | |||
|
|
|||
| // Check if the optional frame_rate is present and set it if it exists | |||
| if resp.FrameRate != nil { | |||
There was a problem hiding this comment.
We need this check because if we attempt dereference the pointer when nil we will get a panic?
There was a problem hiding this comment.
Yes - we will get undefined behavior if we dereference a null pointer so that is why i put that check in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by the API changes being merged (API PR #553)
frame_rateto the properties structframe_ratetocamera_test.goand tested for when frame_rate is set vs not set (since it is optional)frame_rateto the client and server files for go SDKframe_rateto camera'sclient_test.goandserver_test.goto test for when frame_rate is set vs not set